Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial subspace-gateway binary which does nothing #3131

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

teor2345
Copy link
Member

@teor2345 teor2345 commented Oct 16, 2024

This PR creates a subspace-gateway binary, but that binary doesn't actually do anything yet. The binary is based on the node and farmer implementations, with some simplifications.

I decided to call it subspace-gateway to keep the command name short, but not too generic.

Future PRs will add RPCs and DSN piece retrieval.

Code contributor checklist:

@teor2345 teor2345 added the enhancement New feature or request label Oct 16, 2024
@teor2345 teor2345 self-assigned this Oct 16, 2024
Copy link
Member

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this should be closer to farmer rather than node in not relying on anything Substrate-specific from polkadot-sdk.

Also it is a bit of an odd one without anything actually implemented. I often start in a similar way, but open a PR with refactoring or some foundational work (like #3126 or #3128) once I have the next step done or close to it such that I know it'll work with higher probability.

I don't mind merging as is, just feels strange to have in the repo.

@teor2345 teor2345 added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit 825f36f Oct 17, 2024
10 checks passed
@teor2345 teor2345 deleted the sub-gateway branch October 17, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants