Improve sync from DSN #1793
Merged
Improve sync from DSN #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
requested review from
ParthDesai,
vedhavyas,
shamil-gadelshin and
rahulksnv
nazar-pc
force-pushed
the
improve-sync-from-dsn
branch
from
beea722 to
a1076dc
Compare
|
Fixed a bit tricky concurrency issue around ordered acquisition of permits in previous revision, now seems to work fine |
shamil-gadelshin
previously approved these changes
Aug 10, 2023
| @@ -319,15 +256,15 @@ where | |||
| downloaded_blocks += 1; | |||
|
|
|||
| if downloaded_blocks % 1000 == 0 { | |||
| info!("Imported block {} from DSN", block_number); | |||
There was a problem hiding this comment.
It was an indicator of the importing progress. Can we add a similar message somewhere?
There was a problem hiding this comment.
You'll see usual sync speed reporting, this is on my machine with sync from DSN:
2023-08-10 17:25:19.419 INFO tokio-runtime-worker substrate: [Consensus] ⚙️ Syncing 12.4 bps, target=#59922 (6 peers), best: #50026 (0x4a90…cf38), finalized #9199 (0xa7b7…02b7), ⬇ 3.8kiB/s ⬆ 83 B/s
a1076dc to
15fe6f5
Compare
… nothing to import anyway
|
Found that it still pulls unnecessary segment header under certain circumstances. |
nazar-pc
requested review from
shamil-gadelshin
and removed request for
shamil-gadelshin
shamil-gadelshin
approved these changes
Aug 11, 2023
ParthDesai
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Aug 15, 2023
…pace#1791 autonomys/subspace#1786 autonomys/subspace#1787 autonomys/subspace#1785 autonomys/subspace#1783 autonomys/subspace#1761 autonomys/subspace#1782 autonomys/subspace#1784 autonomys/subspace#1778 autonomys/subspace#1776 autonomys/subspace#1762 autonomys/subspace#1772 autonomys/subspace#1777 autonomys/subspace#1767 autonomys/subspace#1775 autonomys/subspace#1768 autonomys/subspace#1771 autonomys/subspace#1760 autonomys/subspace#1766 autonomys/subspace#1742 autonomys/subspace#1765 autonomys/subspace#1770 autonomys/subspace#1764
ParthDesai
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Aug 15, 2023
…pace#1791 autonomys/subspace#1786 autonomys/subspace#1787 autonomys/subspace#1785 autonomys/subspace#1783 autonomys/subspace#1761 autonomys/subspace#1782 autonomys/subspace#1784 autonomys/subspace#1778 autonomys/subspace#1776 autonomys/subspace#1762 autonomys/subspace#1772 autonomys/subspace#1777 autonomys/subspace#1767 autonomys/subspace#1775 autonomys/subspace#1768 autonomys/subspace#1771 autonomys/subspace#1760 autonomys/subspace#1766 autonomys/subspace#1742 autonomys/subspace#1765 autonomys/subspace#1770 autonomys/subspace#1764
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several issues with sync from DSN, I'm surprised it worked at all 🙈
So first I removed initial sync from DSN mode. It doesn't seem to be required anymore since we can discover when node is not synced in runtime just fine.
Then turned out
while block_number - best_block_number >= QUEUED_BLOCKS_LIMIT.into() {was buggy since neitherbest_block_numberwas updated nor blocks were imported in between, essentially making this an infinite loop in case blocks are small enough to accumulate more than 2048 blocks in one segment.Then turned out node was showing 0 peers on Substrate level due to pruned peers responding with no blocks when requested, but when we skip requests we can maintain connections, so I decided to start with paused sync mode and wait for networking to come alive and kick in DSN sync before anything else.
Last commit adds concurrency for piece retrieval, allowing to pull pieces at over 100 Mbps speed easily, making everything move much faster.
As the result sync from DSN should be much less broken than before.
Code contributor checklist: