Filter out DataBinding expressions when extracting resources from xml files #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autonomousapps
requested changes
Jan 4, 2022
|
|
||
| import com.autonomousapps.advice.Advice | ||
|
|
||
| class DataBindingWithExpressionsProject( |
There was a problem hiding this comment.
Please rewrite this fixture to use a similar style to AttrResWithNullProject from the spec just above your new one. This is the first style of fixture used in this project and... I hate it. I'd like to eliminate it entirely at some point.
There was a problem hiding this comment.
Sure, not a problem. Please check my latest commit with an updated DataBindingWithExpressionsProject implementation.
| * | ||
| * Will return `null` if the map entry doesn't match an expected pattern. | ||
| */ | ||
| fun from(mapEntry: Map.Entry<String, String>): AttrRef? { | ||
| if (mapEntry.isId()) return null | ||
| if (mapEntry.isToolsAttr()) return null | ||
| if (mapEntry.isDataBindingExpression()) return null |
There was a problem hiding this comment.
Thank you for updating this in both locations!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried running
buildHealthwith0.79.0version of the plugin and got the same exception as in #531 and #542. The only difference that it has nothing to do with@nullin my case and is actually caused by data binding expressions likebinding:subtitle="@{model.subtitle}".The fix from #534 actually prevents the exception in my case, but it doesn't cover all databinding related scenarios. For example, expressions like
binding:outlineRadius="@{@dimen/radius_normal}"are still parsed as a validAttrRef(type = "{@dimen", id = "radius_normal}")object.This PR introduces the following changes:
AttrRef.fromnow always returnsnullfor all data binding expressions.ResSpec.groovyruns one more case which is specially dedicated to data binding expressions.