Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: can set severity and filter duplicate class warnings. #1340

Merged
merged 2 commits into from
Dec 15, 2024
Merged

feat: can set severity and filter duplicate class warnings. #1340

merged 2 commits into from
Dec 15, 2024

Conversation

autonomousapps
Copy link
Owner

@autonomousapps autonomousapps commented Dec 14, 2024 •
edited
Loading

TODO

  • Add tests

@autonomousapps autonomousapps force-pushed the trobalik.warning-behavior branch from 52e1ce1 to f715ace Compare December 14, 2024 18:03
autonomousapps
autonomousapps commented Dec 14, 2024
View reviewed changes
src/main/kotlin/com/autonomousapps/tasks/FilterAdviceTask.kt
@@ -162,7 +167,11 @@ abstract class FilterAdviceTask @Inject constructor(
.filterNot {
moduleStructureBehavior is Ignore || it.shouldIgnore(moduleStructureBehavior)
}
.toSet()
.toSortedSet()
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have always been sorted.

@autonomousapps
Copy link
Owner Author

Resolves #1330.

@github-actions GitHub Actions
Copy link

❌ Test workflow failed:

* Root buildHealth         : https://gradle.com/s/zvn322742bsdi
* TestKit buildHealth      : 
* Non-functional tests     : 
* TestKit check            : 
* JVM functional tests     : 
* Android functional tests :

@autonomousapps autonomousapps force-pushed the trobalik.warning-behavior branch from f715ace to 94fcafd Compare December 14, 2024 18:16
@github-actions GitHub Actions
Copy link

❌ Test workflow failed:

* Root buildHealth         : https://gradle.com/s/ac6u42fdxn5zu
* TestKit buildHealth      : https://gradle.com/s/jr3o7hnzummfi
* Non-functional tests     : https://gradle.com/s/qjhazf6z4dftk
* TestKit check            : 
* JVM functional tests     : 
* Android functional tests :

@autonomousapps autonomousapps force-pushed the trobalik.warning-behavior branch from 94fcafd to 4d4fdd7 Compare December 14, 2024 21:41
@autonomousapps autonomousapps force-pushed the trobalik.warning-behavior branch from 4d4fdd7 to fbb2a6c Compare December 15, 2024 01:44
@autonomousapps autonomousapps marked this pull request as ready for review December 15, 2024 18:30
@autonomousapps autonomousapps merged commit af67f37 into main Dec 15, 2024
1 check passed
@autonomousapps autonomousapps deleted the trobalik.warning-behavior branch December 15, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@autonomousapps