Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjust shadow plugin coordinates #1339

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

patrick-dedication
Copy link

The plugin was relocated see here.
Version 8.3.0 is very similar to 8.1.1, the gradle requirement was bumped to 8.3 which shouldn't be an issue since you are using 8.11 as far as I can tell.

Copy link
Owner

@autonomousapps autonomousapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

id("org.gradle.toolchains.foojay-resolver-convention") version("0.8.0")
id("org.gradle.toolchains.foojay-resolver-convention") version ("0.8.0")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this either shouldn't have a space or should remove the ()

Copy link
Author

@patrick-dedication patrick-dedication Dec 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I like it, you pay attention to the details :)
Autoformatting changed it, so I thought I'd add it to the commit.
Reverted the change since it had nothing to do with this PR.
I'll create a new one here to remove the (), so it is more consistent with the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants