Evaluation #26
Closed
Evaluation #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compute the loss on a given set of points
chiragnagpal
reviewed
Jan 2, 2021
dsm/dsm_api.py
Outdated
| @@ -118,6 +118,18 @@ def fit(self, x, t, e, vsize=0.15, | |||
| self.fitted = True | |||
|
|
|||
| return self | |||
|
|
|||
| def eval(self, x, t, e): | |||
There was a problem hiding this comment.
I like this ... can we instead call this function _log_likelihood? or _negative_log_likelihood or something like that ? preferably with an underscore at the start to show that it isn't typically supposed to be used directly ?
chiragnagpal
reviewed
Jan 2, 2021
dsm/dsm_api.py
Outdated
| @@ -31,7 +31,7 @@ | |||
| from dsm.dsm_torch import DeepRecurrentSurvivalMachinesTorch | |||
| from dsm.losses import predict_cdf | |||
| import dsm.losses as losses | |||
| from dsm.utilities import train_dsm, _get_padded_features, _get_padded_targets | |||
| from dsm.utilities import train_dsm, _get_padded_features, _get_padded_targets, _reshape_tensor_with_nans | |||
There was a problem hiding this comment.
break into multiple lines this line is too long
|
Closing this since this PR since it was outdated by https://github.com/autonlab/DeepSurvivalMachines/pull/29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compute the loss on a given set of points