More explicit subsample bounds check #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The subsample float can be further validated via 0<=subsample<1 (not only the upper bound)
|
Hi, Thanks for the PR, I will take a look next week once I am back! Sorry for the delay Best, |
eddiebergman
approved these changes
Aug 3, 2022
Codecov Report
@@ Coverage Diff @@
## development #1545 +/- ##
===============================================
- Coverage 84.38% 84.23% -0.15%
===============================================
Files 154 154
Lines 11694 11694
Branches 2038 2038
===============================================
- Hits 9868 9851 -17
- Misses 1282 1295 +13
- Partials 544 548 +4 |
|
So the test failures seem unrelated to this and I would be willing to just merge the changes. |
eddiebergman
pushed a commit
that referenced
this pull request
Aug 18, 2022
The subsample float can be further validated via 0<=subsample<1 (not only the upper bound)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subsample float can be further validated via 0 <= subsample < 1 (not only the upper bound)