Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to validation set in evaluator #1517

Merged
merged 9 commits into from
Jun 17, 2022
Merged

Remove references to validation set in evaluator #1517

merged 9 commits into from
Jun 17, 2022

Conversation

eddiebergman
Copy link
Contributor

@eddiebergman eddiebergman commented Jun 14, 2022 •
edited
Loading

  • Just search up X_valid, y_valid, validation and cleaned up where I thought it's needed
  • The test file for evaluators is difficult to parse and uses a lot of mocks. There was a lot of magic numbers I just changed to what the tests ended up giving back

@eddiebergman eddiebergman added the maintenance Internal maintenance label Jun 14, 2022
@eddiebergman eddiebergman added this to the V0.15 milestone Jun 14, 2022
@eddiebergman eddiebergman self-assigned this Jun 14, 2022
@codecov
Copy link

codecov bot commented Jun 14, 2022 •
edited
Loading

Codecov Report

Merging #1517 (a5d9a35) into development (b98b3d9) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Current head a5d9a35 differs from pull request most recent head a30b232. Consider uploading reports for the commit a30b232 to get more accurate results

@@               Coverage Diff               @@
##           development    #1517      +/-   ##
===============================================
- Coverage        83.82%   83.76%   -0.06%     
===============================================
  Files              153      153              
  Lines            11698    11698              
  Branches          2046     2046              
===============================================
- Hits              9806     9799       -7     
- Misses            1342     1348       +6     
- Partials           550      551       +1

Impacted file tree graph

eddiebergman and others added 7 commits June 15, 2022 08:17
@eddiebergman
Fix logging server cleanup (#1503)
0ae2463 
* Fix logging server cleanup

* Add comment relating to the `try: finally:`

* Remove nested try: except: from `fit`
@dependabot
Bump peter-evans/find-comment from 1 to 2 (#1520)
8d82be8 
Bumps [peter-evans/find-comment](https://github.com/peter-evans/find-comment) from 1 to 2.
- [Release notes](https://github.com/peter-evans/find-comment/releases)
- [Commits](peter-evans/find-comment@v1...v2)

---
updated-dependencies:
- dependency-name: peter-evans/find-comment
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump actions/stale from 4 to 5 (#1521)
9002fca 
Bumps [actions/stale](https://github.com/actions/stale) from 4 to 5.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v4...v5)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@eddiebergman
Init commit
34d6d0c
@eddiebergman
Merge branch '1474-remove-references-to-validation-set' of github.com…
b7bd0d2 
…:automl/auto-sklearn into 1474-remove-references-to-validation-set
@eddiebergman
Update evaluation module
4468fe9
@eddiebergman
Clean up other occurences of the word validation
9dc7833
@eddiebergman eddiebergman requested a review from mfeurer June 16, 2022 13:41
@eddiebergman
Copy link
Contributor Author

@mfeurer Once these tests pass, it's ready for merge

@mfeurer mfeurer merged commit c69800d into development Jun 17, 2022
@mfeurer mfeurer deleted the 1474-remove-references-to-validation-set branch June 17, 2022 12:26
github-actions bot pushed a commit that referenced this pull request Jun 17, 2022
Eddie Bergman: Remove references to validation set in evaluator (#1517)
c892b18
eddiebergman added a commit that referenced this pull request Aug 18, 2022
@eddiebergman @dependabot
Remove references to validation set in evaluator (#1517)
4b40d45 
* Init commit

* Fix logging server cleanup (#1503)

* Fix logging server cleanup

* Add comment relating to the `try: finally:`

* Remove nested try: except: from `fit`

* Bump peter-evans/find-comment from 1 to 2 (#1520)

Bumps [peter-evans/find-comment](https://github.com/peter-evans/find-comment) from 1 to 2.
- [Release notes](https://github.com/peter-evans/find-comment/releases)
- [Commits](peter-evans/find-comment@v1...v2)

---
updated-dependencies:
- dependency-name: peter-evans/find-comment
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/stale from 4 to 5 (#1521)

Bumps [actions/stale](https://github.com/actions/stale) from 4 to 5.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v4...v5)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Init commit

* Update evaluation module

* Clean up other occurences of the word validation

* Re-add test for test predictions

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfeurer mfeurer mfeurer approved these changes

Assignees

@eddiebergman eddiebergman

Labels
maintenance Internal maintenance
Projects
None yet
Milestone
V0.15
Development

Successfully merging this pull request may close these issues.

Refactor the concept of public and private test set
2 participants
@eddiebergman @mfeurer