Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename rval to return_value or run_value #1504

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Conversation

eddiebergman
Copy link
Contributor

@eddiebergman eddiebergman commented Jun 9, 2022

Closes #1461

Did a big search over all files for rval and just renamed accordingly

@eddiebergman eddiebergman linked an issue Jun 9, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #1504 (df5d48e) into development (0f1f38a) will decrease coverage by 0.03%.
The diff coverage is 82.75%.

@@               Coverage Diff               @@
##           development    #1504      +/-   ##
===============================================
- Coverage        83.79%   83.75%   -0.04%     
===============================================
  Files              152      152              
  Lines            11667    11667              
  Branches          2037     2037              
===============================================
- Hits              9776     9772       -4     
- Misses            1343     1345       +2     
- Partials           548      550       +2     

Impacted file tree graph

@eddiebergman eddiebergman self-assigned this Jun 10, 2022
@eddiebergman eddiebergman added this to the V0.15 milestone Jun 10, 2022
@eddiebergman eddiebergman added the maintenance Internal maintenance label Jun 10, 2022
@mfeurer mfeurer merged commit 4d8401f into development Jun 14, 2022
@mfeurer mfeurer deleted the fix_rval_names branch June 14, 2022 12:35
github-actions bot pushed a commit that referenced this pull request Jun 14, 2022
eddiebergman added a commit that referenced this pull request Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Internal maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename all variables named rval
3 participants