-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix moo things #1501
Merged
Merged
Fix moo things #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfeurer
requested changes
Jun 8, 2022
Codecov Report
@@ Coverage Diff @@
## development #1501 +/- ##
===============================================
- Coverage 83.79% 83.77% -0.02%
===============================================
Files 152 152
Lines 11667 11683 +16
Branches 2037 2044 +7
===============================================
+ Hits 9776 9788 +12
- Misses 1343 1344 +1
- Partials 548 551 +3 |
This was
linked to
issues
Jun 9, 2022
eddiebergman
commented
Jun 9, 2022
Comment on lines
+630
to
+632
|
||
# Add the performance stamp to the history | ||
self.ensemble_history.append(performance_stamp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BUGFIX: Marking this to match PR description, used to be inside the for loop but should have been outside
mfeurer
approved these changes
Jun 14, 2022
eddiebergman
added a commit
that referenced
this pull request
Aug 18, 2022
* Push * `fit_ensemble` now has priority for kwargs to take * Change ordering of prefernce for ensemble params * Add TODO note for metrics * Add `metrics` arg to `fit_ensemble` * Add test for pareto front sizes * Remove uneeded file * Re-added tests to `test_pareto_front` * Add descriptions to test files * Add test to ensure argument priority * Add test to make sure X_data only loaded when required * Remove part of test required for performance history * Default to `self._metrics` if `metrics` not available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builder.py
if a metric needs itensemble_kwargs
#1497fit_ensemble
now accepts metrics to enable the use case listed in [Dev only] MOO ensemble can fail to return pareto front if automl instance consutrcted with single metric #1496.Fixes:
Tests (Tangent):
test_post_fit
andtest_performance
, just reorganizing teststest_output.py
and just merge it withtest_post_fit.py
since theyre mostly similartest_automl/
files to describe them moreNext Steps, will create issues and work on it once this has been merged:
AutoML::performance_over_time
. Thought this is best left for another PR