-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests: 1. automl.py
#1417
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #1417 +/- ##
===============================================
- Coverage 84.59% 84.33% -0.26%
===============================================
Files 146 147 +1
Lines 11295 11293 -2
Branches 1931 1924 -7
===============================================
- Hits 9555 9524 -31
- Misses 1226 1256 +30
+ Partials 514 513 -1 |
This commit (too much) focues on extending our pytest capabilities to make things more modular. Notably, making a fixtures and mocks folders for testing so there is a unified source of mocks and fixture locations. Split the tests for automl.py into seperate sub files to allow for an easier time discerning what is being tested where. Introduces `pytest_cases` to allow for easier future testing of properties. Introduces cached automl models to allow for a quicker time testing attributes while keeping tests seperate and distinct. This also rearragnes `unittest` import unfortunatly which causes many files to be touched.
This was referenced Apr 21, 2022
eddiebergman
added a commit
that referenced
this pull request
Aug 18, 2022
* Add: Dedicated fixtures location * Add: Typing to conftest * Fix: More typing * Move: Dask fixtures to own location * Move: backend to it's own fixture location * Move: Automlstub thing to it's own fixture * Fix: docstring warning in conftest * Fix: Remove dead code * Add: Functionality to skip marked `slow` tests * Add: Fixture for getting datasets * Update: Tests for automl.py w/ fixtures, cases, mocks This commit (too much) focues on extending our pytest capabilities to make things more modular. Notably, making a fixtures and mocks folders for testing so there is a unified source of mocks and fixture locations. Split the tests for automl.py into seperate sub files to allow for an easier time discerning what is being tested where. Introduces `pytest_cases` to allow for easier future testing of properties. Introduces cached automl models to allow for a quicker time testing attributes while keeping tests seperate and distinct. This also rearragnes `unittest` import unfortunatly which causes many files to be touched. * Doc: Add documentation about our testing to conftest.py * Doc: Add a bit more on documenting of tests * Fix: Add pytest-cases to test dependancies * Fix: Broken tests * Fix: Failing test * Fix: Ordering of check in `_includes` * Remove `_includes` and use sets instead * Fix: Black * Update: test workflow knows about `.pytest_cache`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first of a few to address several issues with regards to testing. Notably, it is hard to understand what some tests are actually testing for as well as tests that end up testing multiple things. This first PR updates our testing framework and applies it to the testing of
automl.py
.automl.py
tests into seperate files.AutoML
To address these issues, please refer to the docstring in
conftest.py