Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example to use predefined_split properly #1340

Merged

Conversation

eddiebergman
Copy link
Contributor

From issue #1274, a user was experience issue with PredefinedSplit. It appears that our example on using it was actually using PredefinedSplit incorrectly, specifying indices instead of specifying a boolean mask.

This PR fixes the example

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #1340 (ea54975) into development (b90c228) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1340      +/-   ##
===============================================
+ Coverage        87.90%   87.93%   +0.02%     
===============================================
  Files              140      140              
  Lines            10938    10938              
===============================================
+ Hits              9615     9618       +3     
+ Misses            1323     1320       -3     
Impacted Files Coverage Δ
...learn/pipeline/components/regression/libsvm_svr.py 90.24% <0.00%> (-1.22%) ⬇️
autosklearn/ensemble_builder.py 86.23% <0.00%> (+0.40%) ⬆️
autosklearn/evaluation/abstract_evaluator.py 93.05% <0.00%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b90c228...ea54975. Read the comment docs.

@eddiebergman eddiebergman merged commit 772f268 into development Dec 12, 2021
@eddiebergman eddiebergman deleted the update_resampling_strategy_predefined_split branch December 12, 2021 14:34
@eddiebergman eddiebergman mentioned this pull request Jan 24, 2022
@eddiebergman eddiebergman mentioned this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants