Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docstrings of include and exclude parameters of the estimators #1332

Merged
merged 3 commits into from
Dec 1, 2021
Merged

Update docstrings of include and exclude parameters of the estimators #1332

merged 3 commits into from
Dec 1, 2021

Conversation

eddiebergman
Copy link
Contributor

  • Updates docstrings with more info and an example.
  • Adds types to obvious use places of include and exclude

@eddiebergman eddiebergman linked an issue Dec 1, 2021 that may be closed by this pull request
Docstrings for include and exclude argument not up-to-date #1331
Closed
@codecov
Copy link

codecov bot commented Dec 1, 2021 •
edited
Loading

Codecov Report

Merging #1332 (4265755) into development (0e455bc) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1332      +/-   ##
===============================================
+ Coverage        88.05%   88.06%   +0.01%     
===============================================
  Files              140      140              
  Lines            11165    11166       +1     
===============================================
+ Hits              9831     9833       +2     
+ Misses            1334     1333       -1
Impacted Files Coverage Δ
autosklearn/estimators.py 93.42% <ø> (ø)
autosklearn/automl.py 86.86% <100.00%> (ø)
autosklearn/smbo.py 88.04% <100.00%> (+0.04%) ⬆️
...learn/pipeline/components/regression/libsvm_svr.py 91.46% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e455bc...4265755. Read the comment docs.

@eddiebergman eddiebergman merged commit 0575b75 into development Dec 1, 2021
github-actions bot pushed a commit that referenced this pull request Dec 1, 2021
Eddie Bergman: Update docstrings of include and exclude parameter…
0c188cb 
…s of the estimators (#1332)
@mfeurer mfeurer mentioned this pull request Dec 2, 2021
Closed
@eddiebergman eddiebergman mentioned this pull request Jan 24, 2022
Merged
eddiebergman added a commit that referenced this pull request Jan 25, 2022
@eddiebergman
Update docstrings of include and exclude parameters of the estima…
800912c 
…tors (#1332)

* Update docstrings and types

* doc typo fix

* flake'd
@eddiebergman eddiebergman mentioned this pull request Jan 25, 2022
Merged
@eddiebergman eddiebergman deleted the fix_include_exclude_docstrings branch February 9, 2022 14:27
eddiebergman added a commit that referenced this pull request Aug 18, 2022
@eddiebergman
Update docstrings of include and exclude parameters of the estima…
09e4752 
…tors (#1332)

* Update docstrings and types

* doc typo fix

* flake'd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfeurer mfeurer mfeurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docstrings for include and exclude argument not up-to-date
2 participants
@eddiebergman @mfeurer