Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes linkcheck not build the examples #1231

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Conversation

eddiebergman
Copy link
Contributor

Linkcheck was causing the examples to be built again but that is already done in the doc.yaml workflow with make html.

  • Makes the linkcheck not run the examples when done locally
  • Should half the time for docs to build in the workflow.

@eddiebergman eddiebergman changed the base branch from master to development August 24, 2021 20:49
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #1231 (c307394) into development (4597152) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1231      +/-   ##
===============================================
- Coverage        88.17%   88.13%   -0.04%     
===============================================
  Files              138      138              
  Lines            10866    10866              
===============================================
- Hits              9581     9577       -4     
- Misses            1285     1289       +4     
Impacted Files Coverage Δ
...ine/components/feature_preprocessing/kernel_pca.py 94.73% <0.00%> (-1.76%) ⬇️
...learn/pipeline/components/regression/libsvm_svr.py 90.24% <0.00%> (-1.22%) ⬇️
...ine/components/classification/gradient_boosting.py 93.04% <0.00%> (-0.87%) ⬇️
autosklearn/evaluation/abstract_evaluator.py 92.12% <0.00%> (-0.79%) ⬇️
...ature_preprocessing/select_rates_classification.py 87.32% <0.00%> (+1.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4597152...c307394. Read the comment docs.

Copy link
Contributor

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt that this halves the runtime as examples aren't re-run in case they weren't changed. But I don't mind merging this.

@eddiebergman
Copy link
Contributor Author

Ahh good point, I was thinking from the local perspective more where normally it's a fresh build or I run make clean in between. Either way, it makes it faster to run for contributors or ourselves

@eddiebergman eddiebergman merged commit 8d93737 into development Aug 25, 2021
@eddiebergman eddiebergman deleted the linkcheck_fix branch February 9, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants