Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo and link formatting in FAQ #1195

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Fix typo and link formatting in FAQ #1195

merged 1 commit into from
Jul 30, 2021

Conversation

PGijsbers
Copy link
Contributor

@PGijsbers PGijsbers commented Jul 29, 2021

As per title.

@eddiebergman
Copy link
Contributor

eddiebergman commented Jul 29, 2021

Looks good, thank you very much for the doc fixes, very much appreciated!

Just going to run a quick check to make sure doc still builds correctly

@eddiebergman
Copy link
Contributor

Hmm they're failing to build but it appears to be unrelated, seperate issue that we need to address.

@mfeurer Am I okay to merge simple doc changes such as this?

@mfeurer
Copy link
Contributor

mfeurer commented Jul 29, 2021

Yes, they appear unrelated, you can go ahead an squash merge this thingy.

@PGijsbers
Copy link
Contributor Author

I'm confused, looks like Matthias suggested a merge instead of closing without?

@eddiebergman
Copy link
Contributor

Was there more fixes? I can go ahead and reopen the branch. That was my bad as I assumed that was it for the PR

@PGijsbers
Copy link
Contributor Author

No there wouldn't be any more commits to this branch, because from my understanding Matthias was fine with merging this as-is (and I assume tackle the doc build issues in a separate PR by whomever takes that up).

@eddiebergman
Copy link
Contributor

eddiebergman commented Jul 29, 2021

Ahh okay, yes I documented it in (#1196). We're trying to get some long term plans for auto-sklearn done at the moment but we'll get back to it soon!

@mfeurer
Copy link
Contributor

mfeurer commented Jul 29, 2021

Sorry, my comment was a bit too brief. I'm fine with you merging this, @eddiebergman. And I think the test failures are unrelated to these changes.

@mfeurer mfeurer reopened this Jul 29, 2021
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #1195 (38bcba7) into development (96b9ad0) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #1195   +/-   ##
============================================
  Coverage        88.15%   88.16%           
============================================
  Files              138      138           
  Lines            10866    10866           
============================================
+ Hits              9579     9580    +1     
+ Misses            1287     1286    -1     
Impacted Files Coverage Δ
...ature_preprocessing/select_rates_classification.py 85.91% <0.00%> (-1.41%) ⬇️
...learn/pipeline/components/regression/libsvm_svr.py 90.24% <0.00%> (-1.22%) ⬇️
...ine/components/feature_preprocessing/kernel_pca.py 96.49% <0.00%> (+1.75%) ⬆️
...eline/components/feature_preprocessing/fast_ica.py 97.82% <0.00%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96b9ad0...38bcba7. Read the comment docs.

@eddiebergman eddiebergman merged commit 832b412 into automl:development Jul 30, 2021
@eddiebergman
Copy link
Contributor

eddiebergman commented Jul 30, 2021

@PGijsbers @mfeurer I realise the confusion now ... I thought I hit merge but apparently not -_-

My bad!

@PGijsbers
Copy link
Contributor Author

Don't worry about it, glad it's resolved!

github-actions bot pushed a commit that referenced this pull request Jul 30, 2021
eddiebergman pushed a commit that referenced this pull request Aug 18, 2021
@PGijsbers PGijsbers deleted the fix-faq branch February 19, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants