-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo and link formatting in FAQ #1195
Conversation
Looks good, thank you very much for the doc fixes, very much appreciated! Just going to run a quick check to make sure doc still builds correctly |
Hmm they're failing to build but it appears to be unrelated, seperate issue that we need to address. @mfeurer Am I okay to merge simple doc changes such as this? |
Yes, they appear unrelated, you can go ahead an squash merge this thingy. |
I'm confused, looks like Matthias suggested a merge instead of closing without? |
Was there more fixes? I can go ahead and reopen the branch. That was my bad as I assumed that was it for the PR |
No there wouldn't be any more commits to this branch, because from my understanding Matthias was fine with merging this as-is (and I assume tackle the doc build issues in a separate PR by whomever takes that up). |
Ahh okay, yes I documented it in (#1196). We're trying to get some long term plans for auto-sklearn done at the moment but we'll get back to it soon! |
Sorry, my comment was a bit too brief. I'm fine with you merging this, @eddiebergman. And I think the test failures are unrelated to these changes. |
Codecov Report
@@ Coverage Diff @@
## development #1195 +/- ##
============================================
Coverage 88.15% 88.16%
============================================
Files 138 138
Lines 10866 10866
============================================
+ Hits 9579 9580 +1
+ Misses 1287 1286 -1
Continue to review full report at Codecov.
|
@PGijsbers @mfeurer I realise the confusion now ... I thought I hit merge but apparently not -_- My bad! |
Don't worry about it, glad it's resolved! |
As per title.