Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix float128 on 32 bits #1154

Merged
merged 2 commits into from
Jun 25, 2021
Merged

Conversation

franchuterivera
Copy link
Contributor

This PR address the problem from #1127 .

Nevertheless, it is complicated as how many bits are used depends on the OS. For example:

In spite of the names, np.float96 and np.float128 provide only as much precision as np.longdouble, that is, 80 bits on most x86 machines and 64 bits in standard Windows builds.

This PR, at least will prevent auto-sklearn from crashing on this situations.

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #1154 (c0cca43) into development (0982410) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1154      +/-   ##
===============================================
- Coverage        85.83%   85.79%   -0.04%     
===============================================
  Files              137      137              
  Lines            10625    10625              
===============================================
- Hits              9120     9116       -4     
- Misses            1505     1509       +4     
Impacted Files Coverage Δ
autosklearn/automl.py 84.75% <0.00%> (ø)
...eline/components/feature_preprocessing/fast_ica.py 91.30% <0.00%> (-6.53%) ⬇️
...ine/components/feature_preprocessing/kernel_pca.py 94.73% <0.00%> (-1.76%) ⬇️
autosklearn/ensemble_builder.py 76.65% <0.00%> (-0.41%) ⬇️
...ine/components/classification/gradient_boosting.py 92.17% <0.00%> (+0.86%) ⬆️
...ature_preprocessing/select_rates_classification.py 87.32% <0.00%> (+1.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0982410...c0cca43. Read the comment docs.

@mfeurer
Copy link
Contributor

mfeurer commented Jun 16, 2021

This looks like a reasonable fix. As there is a specific np.float96, should we actively support that?

@franchuterivera franchuterivera requested a review from mfeurer June 18, 2021 07:11
@mfeurer mfeurer merged commit 3cbdcc8 into automl:development Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants