Register service with Interceptor, then register multiple decorator, auto apply Interceptor to the outermost decorator #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2024 18:28
These changes introduce new methods to register service middleware in the Autofac library. Also, a new test has been added to Autofac.Specification.Test to ensure that the middleware is getting invoked correctly when a service is registered. These methods allow for more precise control of the pipeline during the resolve request process.
This test verifies that middleware is evaluated correctly when using IfNotRegistered with a service descriptor. It ensures the middleware is invoked during the resolution pipeline as expected.
|
Just Add the unit test for code coverage and create an new pull request, any suggestion, let me know. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1439 +/- ##
===========================================
+ Coverage 79.03% 79.06% +0.02%
===========================================
Files 200 200
Lines 5682 5688 +6
Branches 1143 1143
===========================================
+ Hits 4491 4497 +6
Misses 696 696
Partials 495 495 ☔ View full report in Codecov by Sentry. |
tillig
approved these changes
Dec 16, 2024
You are welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register service with Interceptor, then register multiple decorator, auto apply Interceptor to the outermost decorator
Actually this is the default behaviors when I use autofac 4.x. after upgrade version 8.0.0, this not working any more.
I know explicit configure interceptor on the outermost decorator make it more clarity and flexibility. but I thinks we should keep the original behaviors some how, even it not the default behaviors.
This behaviors will benefit in case when add new decorator, we don't need remove the interceptor and add the interceptor to the new decorator.