-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register mocks as singletons #46
Conversation
It seems like, since the "workaround" is basically to provide a singleton instance anyway... this seems like a reasonable fix. Likely we'll need to release a major version since it'll be a breaking behavioral change, but that's fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One note about the unit test as an example.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #46 +/- ##
========================================
Coverage 93.96% 93.96%
========================================
Files 3 3
Lines 116 116
Branches 20 20
========================================
Hits 109 109
Misses 5 5
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! It will be a bit before I can get a release out with this, but the MyGet feed will have interim builds you can consume if you're in a rush.
@tillig, Hi! Do you have plans to release this? MyGet is down, and I'm having trouble building my projects. Or could you create a prerelease version in NuGet, maybe? |
Thanks for the reminder - let me see if I can get this today. Sorry for the delay! |
6.1.1 just got pushed, should start showing up in NuGet shortly. |
@tillig, thank you! BTW, previously you said that
Just curious, did you change your mind? |
No, I just figured it was fixing a kind of bug, forgot about the major release part, incremented the bug release part, and called it a day. At some point we'll have to drop .NET 5 because it's no longer supported and that will also trigger a major release. Sorry for the confusion, day job is really kicking my ass in recent months so I'm just moving as fast as I can to get things done. Mistakes get made. 🤷 |
Fixes #43