Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shorter timeouts and better config to gRPC dialing in tests #965

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Add shorter timeouts and better config to gRPC dialing in tests #965

merged 1 commit into from
Oct 31, 2022

Conversation

josephschorr
Copy link
Member

Fixes #964

@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Oct 31, 2022
@josephschorr josephschorr marked this pull request as ready for review October 31, 2022 22:06
@josephschorr josephschorr requested review from a team and ecordell October 31, 2022 22:06
ecordell
ecordell approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephschorr josephschorr merged commit 3f78da9 into authzed:main Oct 31, 2022
@josephschorr josephschorr deleted the test-grpc-config branch October 31, 2022 22:20
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ecordell ecordell ecordell approved these changes

Assignees
No one assigned
Labels
area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Certificate rotation test occasionally times out
2 participants
@josephschorr @ecordell