Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a lint check for zerolog expression statements without Send or Msg calls #907

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Add a lint check for zerolog expression statements without Send or Msg calls #907

merged 2 commits into from
Oct 18, 2022

Conversation

josephschorr
Copy link
Member

Fixes #905

@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Oct 17, 2022
@josephschorr josephschorr marked this pull request as ready for review October 17, 2022 19:25
@josephschorr josephschorr requested review from a team and jzelinskie October 17, 2022 19:25
vroldanbet
vroldanbet previously approved these changes Oct 18, 2022
View reviewed changes
jzelinskie
jzelinskie reviewed Oct 18, 2022
View reviewed changes
tools/analyzers/exprstatementcheck/testdata/src/missingsend/log.go
}

func (e *Event) Send() {
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you also need testdata where these types are used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, my file somehow went missing... I just recreated it and added it back

@josephschorr josephschorr merged commit 89d488a into authzed:main Oct 18, 2022
@josephschorr josephschorr deleted the zerolog-lint-check branch October 18, 2022 16:02
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vroldanbet vroldanbet vroldanbet approved these changes

@jzelinskie jzelinskie jzelinskie approved these changes

Assignees
No one assigned
Labels
area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add custom linter to catch zerolog builders without Send
3 participants
@josephschorr @jzelinskie @vroldanbet