disable async logging #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unfortunately nothing is calling Close() on diode.Writer, which means that nothing is flushing out the buffer when the process terminates, and log message are lost on process termination
github-actions
bot
added
area/CLI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
async logging was recently introduced in #844
unfortunately nothing is calling
Close()ondiode.Writer, which means buffer is not being flushed on process termination and causes log messages to get lost.I propose disabling this until we come up with a solution that guarantees no log messages are lost on process termination.
Note: I also upgraded to go 1.19.2 to fix some vulns detected by
govulncheck