default termination-log to disabled to make sure SpiceDB does not fail to start #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vroldanbet
force-pushed
the
default-termination-log-tmp
branch
2 times, most recently
from
ba6891a to
484c53c
Compare
github-actions
bot
added
the
area/tooling
While /dev/termination-log is the default path to termination logs in kube environments, for non-kube environments the process may not have permission to write to this path and would fail to start. This makes the termination log default to disabled if the flag has a value of empty string.
vroldanbet
force-pushed
the
default-termination-log-tmp
branch
from
484c53c to
5c32f8d
Compare
vroldanbet
changed the title
vroldanbet
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
/dev/termination-logis the default path totermination logs in kube environments, for non-kube
environments the process may not have permission
to write to this path and would fail to start.
This makes the termination log default to disabled
if the flag has a value of empty string.