Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gomod: bump cobrautil #1245

Merged
merged 1 commit into from
Apr 3, 2023
Merged

gomod: bump cobrautil #1245

merged 1 commit into from
Apr 3, 2023

Conversation

jzelinskie
Copy link
Member

This changes the default for OTEL sample ratio to be 1% instead of 20%.

Our experience running SpiceDB in production has made it clear that 20% is far too large of a default sample ratio for most deployments.

@jzelinskie jzelinskie added area/CLI Affects the command line area/perf Affects performance or scalability area/observability Affects telemetry data labels Apr 3, 2023
@jzelinskie jzelinskie requested a review from a team April 3, 2023 16:39
@github-actions github-actions bot added the area/dependencies Affects dependencies label Apr 3, 2023
@jzelinskie jzelinskie force-pushed the otel-sample branch 3 times, most recently from b20c6af to a7b907b Compare April 3, 2023 17:16
This changes the default for OTEL sample ratio to
be 1% instead of 20%.

Our experience running SpiceDB in production has
made it clear that 20% is far too large of a
default sample ratio for most deployments.
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jzelinskie jzelinskie merged commit ec9cef3 into authzed:main Apr 3, 2023
@jzelinskie jzelinskie deleted the otel-sample branch April 3, 2023 19:53
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/CLI Affects the command line area/dependencies Affects dependencies area/observability Affects telemetry data area/perf Affects performance or scalability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants