Fix deduplication bug in reachable resources #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/dispatch
josephschorr
force-pushed
the
reachable-resources-duplicate-path
branch
2 times, most recently
from
0455091 to
94da686
Compare
josephschorr
force-pushed
the
reachable-resources-duplicate-path
branch
from
94da686 to
6b5696a
Compare
We were previously deduplicating dispatching in reachable resources based solely on the subject found, but without being transformed for the parent resource type. This resulted in branches that produced the *same* subject, but with a different relation, being skipped occasionally due to a race in the dispatching. We now do the duplication check at the dispatch point, to ensure we're checking the exact subject being dispatched. Also adds a consistency test which reproduces the issue. Thanks to `tr33` from Discord for the bug report and reproduction case!
josephschorr
force-pushed
the
reachable-resources-duplicate-path
branch
from
6b5696a to
1438cf2
Compare
vroldanbet
approved these changes
Apr 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously deduplicating dispatching in reachable resources based solely on the subject found, but without being transformed for the parent resource type. This resulted in branches that produced the same subject, but with a different relation, being skipped occasionally due to a race in the dispatching.
We now do the duplication check at the dispatch point, to ensure we're checking the exact subject being dispatched.
Also adds a consistency test which reproduces the issue. Thanks to
tr33from Discord for the bug report and reproduction case!