Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bulk check permissions test #132

Merged
merged 6 commits into from
Oct 3, 2024
Merged

Conversation

tstirrat15
Copy link
Contributor

Fixes #131

Description

There wasn't a test validating that check_bulk_permissions works, or example usage of check_bulk_permissions. This addresses the first and partially addresses the second.

Changes

  • Add new test
  • Add .ruby-version file for rvm etc
  • Bump buf.gen.yaml to v2
  • Bump some deps

Testing

Review. See that things pass.

@tstirrat15 tstirrat15 requested a review from a team October 2, 2024 18:24
alecmerdler
alecmerdler previously approved these changes Oct 2, 2024
Copy link
Contributor

@vroldanbet vroldanbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running buf generate works for me. running the buf YAML file as a script throws an error. It worked when I added --template back

Failure: :2:1 unknown field "version", expected one of [file]
   2 | version: "v2"
   2 | ^

:3:1 unknown field "plugins", expected one of [file]
   3 | plugins:
   3 | ^

:8:1 unknown field "inputs", expected one of [file]
   8 | inputs:
   8 | ^

Copy link
Contributor

@vroldanbet vroldanbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add --template back to the buf yaml 🙏🏻

@vroldanbet vroldanbet merged commit dd2a4e9 into main Oct 3, 2024
8 checks passed
@vroldanbet vroldanbet deleted the add-bulk-check-permissions-test branch October 3, 2024 09:16
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please Add permissions_service.check_bulk_permissions
3 participants