Skip to content
This repository has been archived by the owner on Aug 14, 2020. It is now read-only.

Setup CSS bundling, add bootstrap/normalize stylesheets #4

Merged
merged 7 commits into from
May 20, 2020
Merged

Setup CSS bundling, add bootstrap/normalize stylesheets #4

merged 7 commits into from
May 20, 2020

Conversation

Arthelon
Copy link
Contributor

@Arthelon Arthelon commented May 19, 2020 •
edited
Loading

This PR addresses #1

  • Sets up CSS bundling using Svelte preprocessor hooks
  • Adds stylesheet for bootstrap-grid and normalize.css

@Arthelon Arthelon requested a review from kiootic May 19, 2020 06:49
@Arthelon Arthelon self-assigned this May 19, 2020
kiootic
kiootic reviewed May 19, 2020
View reviewed changes
Copy link
Contributor

@kiootic kiootic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold this PR after #5 is merged, so that we can test the full CI flow.

src/template.html Outdated Show resolved Hide resolved
@Arthelon Arthelon removed their assignment May 19, 2020
@Arthelon Arthelon requested a review from kiootic May 19, 2020 08:49
@kiootic
Copy link
Contributor

kiootic commented May 19, 2020

@Arthelon Please rebase on master branch.

@Arthelon Arthelon force-pushed the add-cdn-links branch 3 times, most recently from 8fe5ef4 to edf709d Compare May 20, 2020 02:27
@Arthelon Arthelon changed the title Add CDN links for bootstrap/normalize Setup CSS bundling, add bootstrap/normalize stylesheets May 20, 2020
kiootic
kiootic reviewed May 20, 2020
View reviewed changes
Copy link
Contributor

@kiootic kiootic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting this error when running npm run dev:

✗ client
'import' and 'export' may only appear at the top level
11: }
12: 
13: export function connect(port) {
    ^
14:   if (source || !window.EventSource) return;

Do you know why/how to fix it?

src/routes/_layout.svelte Outdated Show resolved Hide resolved
louischan-oursky
louischan-oursky reviewed May 20, 2020
View reviewed changes
rollup.config.js Outdated Show resolved Hide resolved
@Arthelon
Copy link
Contributor Author

Arthelon commented May 20, 2020 •
edited
Loading

Seems to be an unresolved issue with rollup/sapper: sveltejs/sapper#1151 . I will try to find a fix.

@Arthelon Arthelon requested a review from kiootic May 20, 2020 04:34
kiootic
kiootic reviewed May 20, 2020
View reviewed changes
src/routes/_layout.svelte Outdated Show resolved Hide resolved
@Arthelon
Downgrade @rollup/plugin-commonjs to fix sapper dev bug
d0a18bd 
Previously, when running the 'dev' npm command. Sapper would spit out
the following error message:
"'import' and 'export' may only appear at the top level "

This issue is related to sapper and the commmonjs rollup plugin: rollup/plugins#304

Resolve temporarily by downgrading @rollup/plugin-commonjs to 11.0.2
Signed-off-by: Arthelon <[email protected]>
@Arthelon Arthelon requested a review from kiootic May 20, 2020 04:52
@kiootic kiootic merged commit 3579462 into authgear:master May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@louischan-oursky louischan-oursky louischan-oursky left review comments

@kiootic kiootic kiootic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arthelon @kiootic @louischan-oursky