Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(golangci-lint): fix revive false positives #3992

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Conversation

nightah
Copy link
Member

@nightah nightah commented Sep 9, 2022

No description provided.

@authelia
Copy link

authelia bot commented Sep 9, 2022

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:ci-fix-revive-linter
  • docker pull ghcr.io/authelia/authelia:ci-fix-revive-linter

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #3992 (e46b0ba) into master (9db4099) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3992      +/-   ##
==========================================
- Coverage   69.17%   69.10%   -0.08%     
==========================================
  Files         257      257              
  Lines       16046    16046              
  Branches      414      414              
==========================================
- Hits        11100    11088      -12     
- Misses       4258     4269      +11     
- Partials      688      689       +1     
Flag Coverage Δ
backend 69.73% <ø> (-0.07%) ⬇️
frontend 63.10% <ø> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/session/types.go 50.00% <0.00%> (-50.00%) ⬇️
web/src/views/LoginPortal/SecondFactor/OTPDial.tsx 90.47% <0.00%> (-9.53%) ⬇️
internal/regulation/regulator.go 94.00% <0.00%> (-6.00%) ⬇️
internal/session/provider.go 59.61% <0.00%> (-1.93%) ⬇️
...LoginPortal/SecondFactor/OneTimePasswordMethod.tsx 93.93% <0.00%> (-1.52%) ⬇️
internal/storage/sql_provider.go 50.52% <0.00%> (-0.35%) ⬇️

@nightah nightah merged commit 4e88698 into master Sep 9, 2022
@nightah nightah deleted the ci-fix-revive-linter branch September 9, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant