Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Prompt Values to auth0_prompt_custom_text Resource #985

Conversation

naari3
Copy link
Contributor

@naari3 naari3 commented Jul 12, 2024

🔧 Changes

  • Added new prompt values to the auth0_prompt_custom_text resource.
  • Updated the documentation to reflect the new prompt values.
  • This change allows for more customization in the login flow by supporting additional prompts such as captcha, custom-form, customized-consent, passkeys, phone-identifier-challenge, and phone-identifier-enrollment.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A) N/A
  • I have added documentation for all new/changed functionality (or N/A)

@naari3 naari3 requested a review from a team as a code owner July 12, 2024 09:13
Copy link
Contributor

@developerkunal developerkunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @naari3,

I have added comments and changes. Please follow them and make the necessary fixes.

internal/auth0/prompt/resource_custom_text.go Outdated Show resolved Hide resolved
docs/resources/prompt_custom_text.md Outdated Show resolved Hide resolved
@naari3 naari3 force-pushed the add-new-prompt-values-to-auth0_prompt_custom_text branch from 6a90eb4 to b840554 Compare July 12, 2024 09:51
@naari3 naari3 requested a review from developerkunal July 12, 2024 09:52
@naari3
Copy link
Contributor Author

naari3 commented Jul 12, 2024

@developerkunal Addressed the comments and pushed updates. Please review again. Thanks!

@developerkunal developerkunal changed the title Add new prompt values to auth0_prompt_custom_text resource Add New Prompt Values to auth0_prompt_custom_text Resource Jul 12, 2024
Copy link
Contributor

@developerkunal developerkunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @naari3,

Thanks for the contribution! Your changes look good to me.

@developerkunal developerkunal merged commit 867a976 into auth0:main Jul 12, 2024
6 checks passed
@naari3 naari3 deleted the add-new-prompt-values-to-auth0_prompt_custom_text branch July 12, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants