-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for show_as_button and is_signup_enabled #974
Merged
acwest
merged 4 commits into
main
from
DXCDT-641-terraform-provider-updates-to-support-Signing-up-with-Organization-Membership
Jun 18, 2024
Merged
Add support for show_as_button and is_signup_enabled #974
acwest
merged 4 commits into
main
from
DXCDT-641-terraform-provider-updates-to-support-Signing-up-with-Organization-Membership
Jun 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
reviewed
Jun 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #974 +/- ##
==========================================
+ Coverage 90.24% 90.28% +0.03%
==========================================
Files 103 103
Lines 13866 13910 +44
==========================================
+ Hits 12514 12558 +44
Misses 961 961
Partials 391 391
|
acwest
force-pushed
the
DXCDT-641-terraform-provider-updates-to-support-Signing-up-with-Organization-Membership
branch
from
June 14, 2024 19:27
d5dbf32
to
a44c261
Compare
sergiught
reviewed
Jun 17, 2024
acwest
force-pushed
the
DXCDT-641-terraform-provider-updates-to-support-Signing-up-with-Organization-Membership
branch
from
June 17, 2024 13:40
a44c261
to
937ca70
Compare
sergiught
reviewed
Jun 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're almost there! This was a big one 💪🏻 good job so far!
acwest
force-pushed
the
DXCDT-641-terraform-provider-updates-to-support-Signing-up-with-Organization-Membership
branch
from
June 17, 2024 16:58
5a592af
to
d01d028
Compare
sergiught
suggested changes
Jun 18, 2024
sergiught
approved these changes
Jun 18, 2024
acwest
deleted the
DXCDT-641-terraform-provider-updates-to-support-Signing-up-with-Organization-Membership
branch
June 18, 2024 13:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
is_signup_enabled
andshow_as_button
flags with Organization Connection resources📚 References
🔬 Testing
There should be more test cases for failure cases:
is_signup_enabled
whenassign_membership_on_login
isfalse
or on a non-db connection should failshow_as_button
to false on a non-enterprise connection should fail📝 Checklist