Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for show_as_button and is_signup_enabled #974

Conversation

acwest
Copy link
Contributor

@acwest acwest commented Jun 14, 2024

🔧 Changes

  • Add support for is_signup_enabled and show_as_button flags with Organization Connection resources

📚 References

🔬 Testing

There should be more test cases for failure cases:

  • setting is_signup_enabled when assign_membership_on_login is false or on a non-db connection should fail
  • setting show_as_button to false on a non-enterprise connection should fail

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@acwest acwest requested a review from a team as a code owner June 14, 2024 16:54
internal/auth0/organization/flatten.go Outdated Show resolved Hide resolved
internal/auth0/organization/flatten.go Outdated Show resolved Hide resolved
internal/auth0/organization/flatten.go Outdated Show resolved Hide resolved
internal/auth0/organization/flatten.go Outdated Show resolved Hide resolved
internal/auth0/organization/resource_connection.go Outdated Show resolved Hide resolved
internal/auth0/organization/resource_connection.go Outdated Show resolved Hide resolved
internal/auth0/organization/resource_connection_test.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.28%. Comparing base (5b2e3ed) to head (e57b4a8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #974      +/-   ##
==========================================
+ Coverage   90.24%   90.28%   +0.03%     
==========================================
  Files         103      103              
  Lines       13866    13910      +44     
==========================================
+ Hits        12514    12558      +44     
  Misses        961      961              
  Partials      391      391              
Files Coverage Δ
internal/auth0/organization/data_source.go 89.76% <100.00%> (+1.16%) ⬆️
internal/auth0/organization/expand.go 100.00% <100.00%> (ø)
internal/auth0/organization/flatten.go 100.00% <100.00%> (ø)
internal/auth0/organization/resource_connection.go 88.23% <100.00%> (+0.60%) ⬆️
...nternal/auth0/organization/resource_connections.go 88.14% <100.00%> (+1.21%) ⬆️

@acwest acwest force-pushed the DXCDT-641-terraform-provider-updates-to-support-Signing-up-with-Organization-Membership branch from d5dbf32 to a44c261 Compare June 14, 2024 19:27
@developerkunal developerkunal requested a review from sergiught June 14, 2024 19:32
@acwest acwest enabled auto-merge (squash) June 14, 2024 19:58
@acwest acwest force-pushed the DXCDT-641-terraform-provider-updates-to-support-Signing-up-with-Organization-Membership branch from a44c261 to 937ca70 Compare June 17, 2024 13:40
@acwest acwest disabled auto-merge June 17, 2024 13:49
Copy link
Contributor

@sergiught sergiught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're almost there! This was a big one 💪🏻 good job so far!

@acwest acwest force-pushed the DXCDT-641-terraform-provider-updates-to-support-Signing-up-with-Organization-Membership branch from 5a592af to d01d028 Compare June 17, 2024 16:58
@acwest acwest enabled auto-merge (squash) June 17, 2024 19:06
@acwest acwest merged commit a57c0ca into main Jun 18, 2024
6 checks passed
@acwest acwest deleted the DXCDT-641-terraform-provider-updates-to-support-Signing-up-with-Organization-Membership branch June 18, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants