Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auth0_tenant data source #95

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

impl
Copy link
Contributor

@impl impl commented Mar 24, 2022

Description

This is a replacement for #84, because I didn't realize changing the branch name would close that PR. 😞

It addresses the feedback in #84 (review), including an added example. The original description is below for posterity:

This change adds a new data source, auth0_tenant, which simply returns some helpful information about the current provider configuration. It is particularly helpful when developing a reusable module that expects this provider as an input, because the module may need to know the domain for downstream configuration (e.g. of frontend applications for redirects) or to set up client grants against the management API.

Checklist

Note: Checklist required to be completed before a PR is considered to be reviewable.

Auth0 Code of Conduct

Auth0 General Contribution Guidelines

Changes include test coverage?

  • Yes
  • Not needed

Does the description provide the correct amount of context?

  • Yes, the description provides enough context for the reviewer to understand what these changes accomplish

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

Is this code ready for production?

  • Yes, all code changes are intentional and no debugging calls are left over

@impl impl requested a review from a team as a code owner March 24, 2022 07:05
willvedd
willvedd previously approved these changes Mar 24, 2022
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and thanks for the contribution!

Copy link
Contributor

@sergiught sergiught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @impl ! Great work here, just left 2 tiny comments.

@impl impl force-pushed the add-tenant-data-source branch from 7dda41c to 2b6fdf6 Compare March 28, 2022 19:20
@impl impl requested a review from sergiught March 28, 2022 19:25
Copy link
Contributor

@sergiught sergiught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an excellent contribution @impl Thank you honestly so much for this and all the hard work put into it. 💪🏻

Apologies it took a while to get to this point. We're merging this in and will make a release till the end of the week most likely.

@sergiught sergiught merged commit 39d1389 into auth0:main Mar 29, 2022
@impl impl deleted the add-tenant-data-source branch March 29, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants