Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESD-32354: Add disable_self_service_change_password to AD connection options #874

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

Adds support for disable_self_service_change_password on AD Connection Options.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught requested a review from a team as a code owner November 8, 2023 12:54
@sergiught sergiught marked this pull request as draft November 8, 2023 12:55
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

Merging #874 (8686f45) into main (ec17aa7) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #874      +/-   ##
==========================================
- Coverage   90.03%   89.99%   -0.05%     
==========================================
  Files         101      101              
  Lines       13781    13783       +2     
==========================================
- Hits        12408    12404       -4     
- Misses        973      977       +4     
- Partials      400      402       +2     
Files Coverage Δ
internal/auth0/connection/expand.go 92.08% <100.00%> (+<0.01%) ⬆️
internal/auth0/connection/flatten.go 79.59% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

@sergiught sergiught force-pushed the ESD-32354-AD-Connection-Attribute branch from a0c0fda to 4e8eb0c Compare November 10, 2023 17:02
@sergiught sergiught marked this pull request as ready for review November 10, 2023 17:02
@sergiught sergiught merged commit 443d088 into main Nov 14, 2023
6 checks passed
@sergiught sergiught deleted the ESD-32354-AD-Connection-Attribute branch November 14, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants