Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node18 GA option to actions runtime #803

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Add node18 GA option to actions runtime #803

merged 2 commits into from
Aug 31, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

Adds node18 GA version on main so we can release v0.50.2 for folks before EOL for node18-beta (node18).

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught requested a review from a team as a code owner August 31, 2023 10:29
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023

Codecov Report

Merging #803 (cc5a2fc) into main (ecc8bb9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #803   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files          83       83           
  Lines       12514    12515    +1     
=======================================
+ Hits        10851    10852    +1     
  Misses       1264     1264           
  Partials      399      399           
Files Changed Coverage Δ
internal/auth0/action/resource.go 86.03% <100.00%> (+0.06%) ⬆️

Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm now realizing that this may require a change to the migration guide too.

@sergiught sergiught requested a review from willvedd August 31, 2023 12:49
@sergiught sergiught merged commit 5be3396 into main Aug 31, 2023
@sergiught sergiught deleted the patch/node-18-ga branch August 31, 2023 13:44
sergiught added a commit that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants