Pass-through un-configurable options for enterprise connections

[sergiught]

🔧 Changes

A notable behavior of the management API's PATCH /api/v2/connections/{id} endpoint is that the options property does not abide by normal PATCH conventions. Instead, the entire object will be replaced by the one provided in the PATCH payload.
This behavior is problematic because there are several unconfigurable connection options for various connection types that need to be preserved for the connection to operate properly. This PR attempts to preserve several of these by reading the current connection options and "passing-through" several of them to the PATCH payload.
Granted, this is a short-term solution. Long-term, we'll need to devise a more holistic solution to avoid frequent, persistent updates to these pass-through properties.

This is a refactor from the fix introduced on v0.

📚 References

• TRACKAI-2061: Pass-through unconfigurable connection options #786

🔬 Testing

📝 Checklist

• All new/changed/fixed functionality is covered by tests (or N/A)
• I have added documentation for all new/changed functionality (or N/A)

[codecov-commenter]

Codecov Report

Merging #802 (4ea953b) into patch/enterprise-connection-options (bfb9f2b) will decrease coverage by 0.07%.
The diff coverage is 85.93%.

Additional details and impacted files

@@                           Coverage Diff                           @@
##           patch/enterprise-connection-options     #802      +/-   ##
=======================================================================
- Coverage                                90.51%   90.44%   -0.07%     
=======================================================================
  Files                                       99       99              
  Lines                                    13226    13350     +124     
=======================================================================
+ Hits                                     11972    12075     +103     
- Misses                                     889      903      +14     
- Partials                                   365      372       +7     

Files Changed	Coverage Δ
internal/auth0/connection/expand.go	94.74% <85.93%> (-1.92%)	⬇️

... and 2 files with indirect coverage changes

[willvedd]

This is definitely more organized than before 👍 . Only a couple small suggestions.

[willvedd]

I realized after the initial implementation is that we should perform a nil check against existingConnection.Options before the type assertion.

[sergiught]

Just curious: Can an already created enterprise connection, not have any options defined? 🤔

I added a nil check in which case we'll skip over the func call.

[willvedd]

I'm actually not sure and to your point, even if it were possible it should be incredibly rare. This would only be precautionary since we've seen occasional panics with type assertions. If you are certain that it is not applicable here, we can remove.

[sergiught]

Don't mind keeping the check for now.

[willvedd]

👍

[willvedd]

Suggested change

	# passThroughUnconfigurableConnectionOptions maintains crucial connection options by forwarding them from the current options to the PATCH payload
	# This is necessary because the /api/v2/connections/{id}, endpoint does not follow usual
	# PATCH behavior, the 'options' property is entirely replaced by the payload object.

Or something similar.