Refactor connection expand func #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v1 #800 +/- ##
==========================================
+ Coverage 90.49% 90.51% +0.02%
==========================================
Files 99 99
Lines 13256 13226 -30
==========================================
- Hits 11996 11972 -24
+ Misses 893 889 -4
+ Partials 367 365 -2
|
willvedd
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
This PR simplifies the expand logic for the connection resources, primarily it reduces cyclomatic complexity (how many independent paths or decision points exist within a piece of code) by transforming the switch statement into a hash map.
📚 References
🔬 Testing
📝 Checklist