Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ShowAsButton option for enterprise connections #80

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Add ShowAsButton option for enterprise connections #80

merged 2 commits into from
Mar 4, 2022

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Mar 4, 2022 •
edited
Loading

Description

Add a new show_as_button option to be able to show a connection as a button.

This fixes: #57.
Continues from: #69.

Checklist

Note: Checklist required to be completed before a PR is considered to be reviewable.

Auth0 Code of Conduct

Auth0 General Contribution Guidelines

Changes include test coverage?

  • Yes
  • Not needed

Does the description provide the correct amount of context?

  • Yes, the description provides enough context for the reviewer to understand what these changes accomplish

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

Is this code ready for production?

  • Yes, all code changes are intentional and no debugging calls are left over

@sergiught sergiught self-assigned this Mar 4, 2022
@sergiught sergiught changed the title Patch/show as button Add ShowAsButton option for enterprise connections Mar 4, 2022
@sergiught sergiught marked this pull request as ready for review March 4, 2022 11:57
@sergiught sergiught requested a review from a team as a code owner March 4, 2022 11:57
@sergiught sergiught mentioned this pull request Mar 4, 2022
Closed
willvedd
willvedd approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @mdreizin! Thanks for helping us push this forward.

@sergiught sergiught merged commit 81c4641 into main Mar 4, 2022
@sergiught sergiught deleted the patch/show-as-button branch March 4, 2022 15:40
@sergiught sergiught mentioned this pull request Mar 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willvedd willvedd willvedd approved these changes

Assignees

@sergiught sergiught

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow enabling "Connection button" for Azure Active Directory enterprise connection (waad)
2 participants
@sergiught @willvedd