GH-790: Improve logstream resource schema #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v1 #798 +/- ##
==========================================
+ Coverage 90.43% 90.48% +0.05%
==========================================
Files 99 99
Lines 13189 13259 +70
==========================================
+ Hits 11928 11998 +70
Misses 893 893
Partials 368 368
|
willvedd
reviewed
Aug 29, 2023
| Optional: true, | ||
| RequiredWith: []string{"sink.0.http_endpoint", "sink.0.http_authorization", "sink.0.http_content_type"}, | ||
| Type: schema.TypeString, | ||
| Optional: true, |
There was a problem hiding this comment.
May need to be computed too?
willvedd
approved these changes
Aug 29, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
After having revisited the api2 json schemas, we adjust the logstream resource schema accordingly.
📚 References
🔬 Testing
📝 Checklist