Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-519: Improve DX for managing is_token_endpoint_ip_header_trusted on auth0_client resource #796

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

At the moment we only allow managing the is_token_endpoint_ip_header_trusted property of the client when the resource gets updated; on create it gets skipped. This unfortunately requires 2 terraform applies in combination with an auth0_client_credentials resource.

To avoid having to run 2 terraform applies, on create if the is_token_endpoint_ip_header_trusted is set, we default the authentication method (token_endpoint_auth_method) of the client to client_secret_post.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2023

Codecov Report

Merging #796 (6ac4399) into v1 (308cc6a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##               v1     #796      +/-   ##
==========================================
+ Coverage   90.43%   90.44%   +0.01%     
==========================================
  Files          99       99              
  Lines       13189    13193       +4     
==========================================
+ Hits        11928    11933       +5     
  Misses        893      893              
+ Partials      368      367       -1     
Files Changed Coverage Δ
internal/auth0/client/expand.go 91.76% <100.00%> (+0.01%) ⬆️
internal/auth0/client/resource.go 98.84% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

docs/resources/client.md Outdated Show resolved Hide resolved
@sergiught sergiught merged commit 318ee75 into v1 Aug 30, 2023
@sergiught sergiught deleted the DXCDT-519-client-is-token-auth-header branch August 30, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants