Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DXCDT-61: Adding attack protection management #77

Merged
merged 18 commits into from
Mar 3, 2022
Merged

DXCDT-61: Adding attack protection management #77

merged 18 commits into from
Mar 3, 2022

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Mar 3, 2022 •
edited
Loading

Description

Introducing the attack protection configurations, and in particular adding:

  • Breached password protection
  • Suspicious IP throttling
  • Brute force configuration

There's quite a bit of typing gymnastics and part of that is do be addressed when we update to Terraform SDK v2.

Checklist

Note: Checklist required to be completed before a PR is considered to be reviewable.

Auth0 Code of Conduct

Auth0 General Contribution Guidelines

Changes include test coverage?

  • Yes
  • Not needed

Does the description provide the correct amount of context?

  • Yes, the description provides enough context for the reviewer to understand what these changes accomplish

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

Is this code ready for production?

  • Yes, all code changes are intentional and no debugging calls are left over

Will Vedder and others added 16 commits March 1, 2022 11:15
Adding attack protection resource, added to provider, updated Go SDK …
a67fab9 
…to 0.6.0
@sergiught
Some fixes during pair programming
f5aa993
Adding docs, example and descriptions
3789ae5
Resolving conflicts
3bb1580
Adding expand functions for breached password detection and brute for…
fe8a69a 
…ce protection
Adding more to documentation
4552c3b
Updating docs and example, fixing issue where nil would be sent inste…
73c245d 
…ad of empty array
Removing commented-out code
ed3a43d
Checking if each subresource has changed
44c26fd
@sergiught
Update attack protection schema
7462718
@sergiught
Add attack protection tests
4c7e673
Continuing work on test
0011ef1 
s
Merging with upstream
6d19b6f
@sergiught
Declare empty slices through literal in attack protection
506a130
Merge branch 'DXCDT-61-attack-protection-management' of https://githu…
6ebd9a9 
…b.com/auth0/terraform-provider-auth0 into DXCDT-61-attack-protection-management
Fixing tests, uncommenting code, adding local referfence to local Go SDK
4cef5c6
@willvedd willvedd requested a review from a team as a code owner March 3, 2022 16:31
willvedd
willvedd commented Mar 3, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
willvedd
willvedd commented Mar 3, 2022
View reviewed changes
go.sum Outdated Show resolved Hide resolved
sergiught
sergiught approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@sergiught sergiught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work on this one 💪🏻

I like how it all came together.

@willvedd willvedd merged commit 13f1e1a into main Mar 3, 2022
@sergiught sergiught deleted the DXCDT-61-attack-protection-management branch April 8, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiught sergiught sergiught approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willvedd @sergiught