Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark signing key as sensitive #72

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

ccogan-lh
Copy link
Contributor

Description

Marking signing key as sensitive to hide output.

Checklist

Note: Checklist required to be completed before a PR is considered to be reviewable.

Auth0 Code of Conduct

Auth0 General Contribution Guidelines

Changes include test coverage?

  • Yes
  • Not needed

Does the description provide the correct amount of context?

  • Yes, the description provides enough context for the reviewer to understand what these changes accomplish

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

Is this code ready for production?

  • Yes, all code changes are intentional and no debugging calls are left over

@ccogan-lh ccogan-lh requested a review from a team as a code owner February 28, 2022 18:02
@ccogan-lh
Copy link
Contributor Author

Apologies for missing this in the first PR.

Copy link
Contributor

@sergiught sergiught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ccogan-lh, no need to apologize, we also missed this when reviewing. We're in this together 💪🏻

What's instead commendable is the fact that you noticed this and made a PR to fix this, so huge thanks for this.

@sergiught sergiught merged commit d7d03e1 into auth0:main Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants