Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-487: Rename scope to scopes in client_grant resource #717

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

Renaming from scope to scopes to better indicate that the property is a list of strings.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught requested a review from a team as a code owner July 13, 2023 18:09
@codecov-commenter
Copy link

Codecov Report

Merging #717 (1db16c1) into v1 (5e45776) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##               v1     #717   +/-   ##
=======================================
  Coverage   87.50%   87.51%           
=======================================
  Files          87       87           
  Lines       13225    13225           
=======================================
+ Hits        11573    11574    +1     
+ Misses       1248     1247    -1     
  Partials      404      404           
Impacted Files Coverage Δ
internal/auth0/client/resource_grant.go 82.45% <100.00%> (+0.87%) ⬆️

@sergiught sergiught merged commit b623d02 into v1 Jul 13, 2023
@sergiught sergiught deleted the patch/rename-grant-scopes branch July 13, 2023 18:56
@sergiught sergiught mentioned this pull request Jul 14, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants