DXCDT-450: Remove deprecated tenant universal login fields #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v1 #712 +/- ##
==========================================
- Coverage 87.50% 87.44% -0.06%
==========================================
Files 85 85
Lines 13392 13312 -80
==========================================
- Hits 11718 11641 -77
+ Misses 1266 1264 -2
+ Partials 408 407 -1
|
sergiught
suggested changes
Jul 13, 2023
| @@ -100,7 +97,6 @@ resource "auth0_tenant" "my_tenant" { | |||
| enabled_locales = ["en", "de", "fr"] | |||
|
|
|||
| flags { | |||
| universal_login = true | |||
There was a problem hiding this comment.
Hm... I think the universal_login flag should probably stay, it's just the block that needs to get removed.
There was a problem hiding this comment.
Nvm, we'll prefer switching the UL exp through the branding resource.
sergiught
force-pushed
the
DXCDT-450-remove-deprecated-universal-login-fields
branch
from
b825a3b to
b4dacd4
Compare
sergiught
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Removing reference to the following deprecated fields in the
auth0_tenantresource:universal_logintenant flag, which is deprecated across entire Auth0 productuniversal_loginblock on schema root which managed colorsRefer to the migration guide for more information on how to manage these deprecations.
📚 References
🔬 Testing
N/A.
📝 Checklist