DXCDT-458: Handling 404 errors in data sources #698
Conversation
| if mErr, ok := err.(management.Error); ok && mErr.Status() == http.StatusNotFound { | ||
| data.SetId("") | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Deleted because we want to handle 404s in the data source.
| if mErr, ok := err.(management.Error); ok && mErr.Status() == http.StatusNotFound { | ||
| data.SetId("") | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Deleted because we want to handle 404s in the data source. This fixes #604 .
| func CheckFor404Error(ctx context.Context, readFunc func(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics, d *schema.ResourceData, m interface{}) diag.Diagnostics { | ||
| diags := readFunc(ctx, d, m) | ||
| if diags != nil { | ||
| return diags | ||
| } | ||
| if d.Id() == "" { | ||
| return diag.FromErr(errors.New("no resource found with that identifier (404)")) | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Aside from abstracting-out each read function and handling the errors within the respective instances (resource vs data source), detecting an empty ID is the simplest solution, albeit not the most elegant.
This is mostly just a proposal of what we could do but at this point I don't think doing a wider refactor would be that much more effort and establishes a better code pattern.
There was a problem hiding this comment.
This is already a solid n+1, we can refactor further after everything's in v1 and we have time. 👍🏻
…into DXCDT-458-handle-404-data-sources
…m/auth0/terraform-provider-auth0 into DXCDT-458-handle-404-data-sources
🔧 Changes
As reported by #604 , there is inconsistent handling of 404 errors within data sources. This is attributed to two reasons:
readFuncbeing repurposed for the correlating data source which normally smooths-over the 404 errorThis PR takes a comprehensive look at each data source and modifies them to handle 404s appropriately.
The approach taken in cases where a resource's read function is repurposed is to wrap that function in a 404 checking function. This was chosen instead of a complete codebase refactor that abstracts the 404 handling for each read funciton.
📚 References
Related Github issue: #604
🔬 Testing
Added tests for each data source.
📝 Checklist