DXCDT-472: Deprecate auth0_tenant.universal-login
#697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
changed the title
auth0_tenant.universal-login
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #697 +/- ##
=======================================
Coverage 86.57% 86.57%
=======================================
Files 83 83
Lines 12413 12414 +1
=======================================
+ Hits 10747 10748 +1
Misses 1267 1267
Partials 399 399
|
Widcket
approved these changes
Jul 10, 2023
willvedd
approved these changes
Jul 10, 2023
sergiught
force-pushed
the
patch/DXCDT-481-ul-tenant
branch
from
dd7c520 to
541f7bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Universal login settings are redundantly placed in both the
auth0_tenantandauth0_brandingresources but should be removed from the tenant resource for simplicity and correctness.📚 References
🔬 Testing
📝 Checklist