DXCDT-472: Add new auth0_pages resource
#691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willvedd
reviewed
Jul 7, 2023
willvedd
reviewed
Jul 7, 2023
willvedd
reviewed
Jul 7, 2023
willvedd
reviewed
Jul 7, 2023
| }, | ||
| ErrorPage: &management.TenantErrorPage{ | ||
| ShowLogLink: auth0.Bool(false), | ||
| URL: auth0.String(""), |
There was a problem hiding this comment.
Maybe clear out the HTML property too?
There was a problem hiding this comment.
Should this be done for the HTML properties of login, change_password, and guardian_mfa as well?
There was a problem hiding this comment.
As long as those pages are disabled, setting the HTML as well to empty is unnecessary. We preferred doing this as a user could in the future come back to these pages and re-enable them with the previous HTML.
willvedd
reviewed
Jul 7, 2023
willvedd
reviewed
Jul 7, 2023
willvedd
reviewed
Jul 7, 2023
sergiught
force-pushed
the
feature/DXCDT-472-pages
branch
from
792a733 to
d1054ff
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #691 +/- ##
==========================================
- Coverage 86.60% 86.57% -0.03%
==========================================
Files 80 83 +3
Lines 12169 12413 +244
==========================================
+ Hits 10539 10747 +208
- Misses 1243 1267 +24
- Partials 387 399 +12
|
Widcket
approved these changes
Jul 10, 2023
This was referenced Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
The
custom_login_pageon theauth0_global_clientand thechange_password,guardian_mfa_pageanderror_pagefields on the
auth0_tenanthave been deprecated in favour of managing them on a brand newauth0_pagesresource.This was done to improve the developer experience and discoverability of these configuration settings.
📚 References
🔬 Testing
📝 Checklist