Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove connection metadata key validation #685

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

ErwinSteffens
Copy link
Contributor

🔧 Changes

Validation on the metadata attribute of the auth0_connection resource now allows only keys with length 0-10 and the description shows a max of 10 metadata values.

I have tested this with the API and you are allowed to:

  • Add key lenghts longer then 255
  • More then 10 metadata items
  • Values cannot be longer then 255

I am not sure about the real limits, but it seems that the validation on the attribute does not match the validation on the API.

📚 References

🔬 Testing

Add connection with following metadata:

resource "auth0_connection" "my-connection" {
  name           = "my-connection"
  display_name   = "My Connection"

  metadata = {
    longer_then_10_chars = "value"
  }
}

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ErwinSteffens ErwinSteffens requested a review from a team as a code owner July 4, 2023 07:28
Copy link
Contributor

@sergiught sergiught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution @ErwinSteffens 💯

@sergiught sergiught merged commit 0f8691f into auth0:main Jul 5, 2023
@ErwinSteffens
Copy link
Contributor Author

Thanks a lot for the contribution @ErwinSteffens 💯

No worries. Do you know when it will be released?

@sergiught
Copy link
Contributor

sergiught commented Jul 6, 2023

@ErwinSteffens I'd say ETA for the upcoming release would be ~1 week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants