[20/X] DXCDT-441: Reintroduce support for zoom client addon #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feature/DXCDT-441-client-addons-zendesk-19 #677 +/- ##
==============================================================================
+ Coverage 87.68% 87.71% +0.03%
==============================================================================
Files 80 80
Lines 12859 12896 +37
==============================================================================
+ Hits 11275 11312 +37
Misses 1211 1211
Partials 373 373
|
Widcket
reviewed
Jun 29, 2023
internal/auth0/client/resource.go
Outdated
| Elem: &schema.Resource{ | ||
| Schema: map[string]*schema.Schema{ | ||
| "account": { | ||
| Description: "Zoom account name usually first segment of your Zoom URL, for " + |
There was a problem hiding this comment.
Suggested change
| Description: "Zoom account name usually first segment of your Zoom URL, for " + | |
| Description: "Zoom account name. Usually the first segment of your Zoom URL, for " + |
sergiught
force-pushed
the
feature/DXCDT-441-client-addons-zendesk-19
branch
2 times, most recently
from
d43a41c to
ac73fd7
Compare
sergiught
force-pushed
the
feature/DXCDT-441-client-addons-zoom-20
branch
from
b89d0e5 to
4bd4346
Compare
Widcket
approved these changes
Jun 29, 2023
Base automatically changed from
feature/DXCDT-441-client-addons-zendesk-19
to
v1
June 29, 2023 16:05
sergiught
force-pushed
the
feature/DXCDT-441-client-addons-zoom-20
branch
from
4bd4346 to
6d3200d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Reintroducing support for zoom client addon on the v1 branch after correctly typing them to the new go-auth0 types.
📚 References
🔬 Testing
📝 Checklist