Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15/X] DXCDT-441: Reintroduce support for sap api client addon #671

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

Reintroducing support for sap api client addon on the v1 branch after correctly typing them to the new go-auth0 types.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught requested a review from a team as a code owner June 28, 2023 12:21
@codecov-commenter
Copy link

Codecov Report

Merging #671 (ee8b434) into feature/DXCDT-441-client-addons-layer-14 (c530576) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                             Coverage Diff                              @@
##           feature/DXCDT-441-client-addons-layer-14     #671      +/-   ##
============================================================================
+ Coverage                                     87.45%   87.53%   +0.07%     
============================================================================
  Files                                            80       80              
  Lines                                         12628    12704      +76     
============================================================================
+ Hits                                          11044    11120      +76     
  Misses                                         1211     1211              
  Partials                                        373      373              
Impacted Files Coverage Δ
internal/auth0/client/expand.go 94.01% <100.00%> (+0.23%) ⬆️
internal/auth0/client/flatten.go 97.62% <100.00%> (+0.12%) ⬆️
internal/auth0/client/resource.go 97.90% <100.00%> (+0.09%) ⬆️

@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-layer-14 branch from c530576 to f41ba46 Compare June 29, 2023 08:03
@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-sap-api-15 branch from ee8b434 to 0e9ee59 Compare June 29, 2023 08:08
@sergiught sergiught requested a review from Widcket June 29, 2023 08:08
@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-layer-14 branch from f41ba46 to 13daed9 Compare June 29, 2023 15:10
Base automatically changed from feature/DXCDT-441-client-addons-layer-14 to v1 June 29, 2023 15:16
@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-sap-api-15 branch from 0e9ee59 to 8e14d0b Compare June 29, 2023 15:17
@sergiught sergiught merged commit ad6ac6f into v1 Jun 29, 2023
@sergiught sergiught deleted the feature/DXCDT-441-client-addons-sap-api-15 branch June 29, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants