Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3/X] DXCDT-441: Reintroduce support for azure sb client addon #657

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

Reintroducing support for azure sb client addon on the v1 branch after correctly typing them to the new go-auth0 types.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught requested a review from a team as a code owner June 26, 2023 16:46
@codecov-commenter
Copy link

Codecov Report

Merging #657 (731ef19) into feature/DXCDT-441-client-addons-azure-2 (52cdcf0) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                             Coverage Diff                             @@
##           feature/DXCDT-441-client-addons-azure-2     #657      +/-   ##
===========================================================================
+ Coverage                                    86.73%   86.80%   +0.07%     
===========================================================================
  Files                                           80       80              
  Lines                                        11938    12007      +69     
===========================================================================
+ Hits                                         10354    10423      +69     
  Misses                                        1211     1211              
  Partials                                       373      373              
Impacted Files Coverage Δ
internal/auth0/client/expand.go 89.20% <100.00%> (+0.73%) ⬆️
internal/auth0/client/flatten.go 95.04% <100.00%> (+0.54%) ⬆️
internal/auth0/client/resource.go 96.86% <100.00%> (+0.18%) ⬆️

@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-azure-2 branch from 52cdcf0 to b75ab94 Compare June 26, 2023 18:22
@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-azure-sb-3 branch from 731ef19 to acf42da Compare June 26, 2023 18:24
@sergiught sergiught requested a review from Widcket June 26, 2023 18:25
@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-azure-2 branch 3 times, most recently from 19b987a to 48d7049 Compare June 27, 2023 14:30
Base automatically changed from feature/DXCDT-441-client-addons-azure-2 to v1 June 27, 2023 15:00
@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-azure-sb-3 branch from acf42da to 5b6d6e8 Compare June 27, 2023 15:04
@sergiught sergiught merged commit b73d86a into v1 Jun 27, 2023
@sergiught sergiught deleted the feature/DXCDT-441-client-addons-azure-sb-3 branch June 27, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants