[3/X] DXCDT-455: Fix permissions update issue in auth0_user_permissions resource #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
commented
Jun 13, 2023
| for _, addPermission := range toAdd { | ||
| permission := addPermission.(map[string]interface{}) | ||
| addPermissions = append(addPermissions, &management.Permission{ | ||
| var rmPermissions []*management.Permission |
There was a problem hiding this comment.
The fix is swapping around the removal and additions. We need to always perform removals first.
sergiught
force-pushed
the
patch/DXCDT-455-import-tests-user-role
branch
from
a6d7c4e to
a9405f9
Compare
sergiught
force-pushed
the
patch/DXCDT-455-import-tests-user-permissions
branch
from
5e6094b to
aa4ca59
Compare
sergiught
force-pushed
the
patch/DXCDT-455-import-tests-user-role
branch
from
a9405f9 to
fbcee2e
Compare
sergiught
force-pushed
the
patch/DXCDT-455-import-tests-user-permissions
branch
from
aa4ca59 to
5633916
Compare
sergiught
force-pushed
the
patch/DXCDT-455-import-tests-user-role
branch
from
fbcee2e to
211b445
Compare
sergiught
force-pushed
the
patch/DXCDT-455-import-tests-user-permissions
branch
from
5633916 to
b1a2616
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## patch/DXCDT-455-import-tests-user-role #630 +/- ##
=======================================================================
Coverage 86.85% 86.85%
=======================================================================
Files 80 80
Lines 12290 12287 -3
=======================================================================
- Hits 10674 10672 -2
Misses 1229 1229
+ Partials 387 386 -1
|
sergiught
force-pushed
the
patch/DXCDT-455-import-tests-user-role
branch
from
211b445 to
449016b
Compare
sergiught
force-pushed
the
patch/DXCDT-455-import-tests-user-permissions
branch
from
b1a2616 to
9712026
Compare
sergiught
force-pushed
the
patch/DXCDT-455-import-tests-user-role
branch
from
449016b to
51ca2c0
Compare
sergiught
force-pushed
the
patch/DXCDT-455-import-tests-user-permissions
branch
from
9712026 to
b0885eb
Compare
willvedd
approved these changes
Jun 13, 2023
sergiught
force-pushed
the
patch/DXCDT-455-import-tests-user-role
branch
from
51ca2c0 to
b84a0d9
Compare
sergiught
force-pushed
the
patch/DXCDT-455-import-tests-user-permissions
branch
from
b0885eb to
76d2456
Compare
Widcket
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Fixes permissions update issue in
auth0_user_permissionsresource.📚 References
🔬 Testing
📝 Checklist