GH-587: Remove computed property from set_user_root_attributes #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
force-pushed
the
patch/GH-587-waad-docs
branch
from
943cd23 to
69be967
Compare
sergiught
commented
May 25, 2023
| @@ -503,19 +503,14 @@ var resourceSchema = map[string]*schema.Schema{ | |||
| }, | |||
|
|
|||
| "set_user_root_attributes": { | |||
| Type: schema.TypeString, | |||
| Optional: true, | |||
| Computed: true, | |||
There was a problem hiding this comment.
If we keep this as computed we won't be able to actually remove it from the update so we can have it use default for WAAD conns.
sergiught
force-pushed
the
patch/GH-587-waad-docs
branch
from
69be967 to
1e7aa67
Compare
sergiught
force-pushed
the
patch/GH-587-waad-docs
branch
from
1e7aa67 to
9ca927a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
As raised in #587 and #83, the Microsoft Azure AD Connection's
set_user_root_attributesbehavior is different than expected. In order to have the user profile sync on each login, this parameter needs to be omitted from the payload. To do so we need to remove the Computed property from the schema for this value. As well we update our docs to reflect this information.📚 References
🔬 Testing
📝 Checklist